From 91a5886df839e56ee838bd8a48bbbc3520cdc61c Mon Sep 17 00:00:00 2001 From: Alex Parsons Date: Mon, 25 Mar 2024 20:17:37 +0000 Subject: [PATCH] fixup! Show number of agreements in top level summary --- classes/Divisions.php | 9 ++------- 1 file changed, 2 insertions(+), 7 deletions(-) diff --git a/classes/Divisions.php b/classes/Divisions.php index 43bfc7ef65..7505916e00 100644 --- a/classes/Divisions.php +++ b/classes/Divisions.php @@ -258,15 +258,8 @@ public function getMemberDivisionDetails($strong_only = false) { $args ); - $policies_list = new \MySociety\TheyWorkForYou\Policies(); - $allowed_policies = $policies_list->getPolicyIDs(); - foreach ($q as $row) { $policy_id = $row['policy_id']; - // deleted policies may still be in the database - ignore them - if (!in_array($policy_id, $allowed_policies)) { - continue; - } if (!array_key_exists($policy_id, $policy_divisions)) { $summary = array( @@ -307,6 +300,8 @@ public function getMemberDivisionDetails($strong_only = false) { } // for each key in $policy_divisions, we want to add agreement information + + $policies_list = new \MySociety\TheyWorkForYou\Policies(); foreach ($policy_divisions as $policy_id => &$summary) { $agreement_details = $this->member->member_agreements($policy_id, HOUSE_TYPE_COMMONS, $policies_list ); $summary["agreements_for"] = 0;