Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

As a citizen with special access needs, I'd like to be able to submit an FOI #22

Closed
garethrees opened this issue Apr 9, 2018 · 2 comments
Assignees
Milestone

Comments

@garethrees
Copy link
Member

No description provided.

@wrightmartin
Copy link
Contributor

wrightmartin commented Jun 11, 2018

Here's the finding from the accessibility review - I understand some of these are related to the template, or even the gov.uk framework so we might decide not to address these here, but to push them upstream

General

  • The green (#0aa44c) used for links fails colour contrast check (3.27:1) on a white background. If you darken it slightly (#08863e) it will pass this is part of the Hackney template gem so we can't fix it here Link and Focus colour accessibility #151

  • The focus colour (#ffbf47) used for links fails colour contrast when used with the link green (#099846) - suggest we change the focus colour to black and keep the background colour as is this is part of the Hackney template gem so we can't fix it here Link and Focus colour accessibility #151

  • There is no landmark role for the page content, suggest adding role=“main” to <div id=“content”> if this is appropriate to address this

Header

  • The logo has no alt text this is part of the Hackney template gem so we can't fix it here The logo has no alt text #144

  • The breadcrumb trail uses an invalid aria role of ‘breadcrumbs’. This should instead be a label aria-label=“breadcrumb” with a role of role=“navigation"

Footer

  • The link colour (#a9cd75) used in the footer fails contrast check on the footer background colour. Lightening it a few steps (#c4dca3) fixes this this is part of the Hackney template gem so we can't fix it here Link and Focus colour accessibility #151

  • The focus colour used for links in the footer, combined with the background fails contrast check this is part of the Hackney template gem so we can't fix it here Link and Focus colour accessibility #151

Homepage

  • ‘By email’ and ‘by post’ should be h4 elements to maintain document structure

  • The focus colour of the ‘start your request’ buttons fails a contrast check Can't reproduce

New request process /foi/request/new

Admin

@garethrees
Copy link
Member Author

Problems that we can't fix have been extracted out in to independent issues.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants