Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

As a mySociety employee, I want to be notified if an FOI request can't be added to Infreemation, so that I can fix the problem #18

Closed
3 tasks done
garethrees opened this issue Apr 9, 2018 · 8 comments
Assignees
Milestone

Comments

@garethrees
Copy link
Member

garethrees commented Apr 9, 2018

@garethrees
Copy link
Member Author

garethrees commented Jun 8, 2018

@sagepe sorry, I didn't get to this. Is it okay if I leave it to you? Just need to lock down /health in the same way as /sidekiq for the production site.

@garethrees garethrees assigned sagepe and unassigned garethrees Jun 8, 2018
@sagepe
Copy link
Member

sagepe commented Jun 11, 2018

I've already prepared this. As it's not specific to this project, I've added it to the shared top-level template. It should be triggered by adding "prometheus_service_health": "/health/metrics" to the deployment JSON (see commit 27a6292b5 in the internal servers repo).

@sagepe
Copy link
Member

sagepe commented Jun 12, 2018

Just noting that the prometheus_service_health key has been added to the staging site JSON ready for the next deploy.

@garethrees
Copy link
Member Author

@sagepe do you consider this "done" now?

I can see that:

  • We have metrics at /health/metrics that has locked down access
  • We receive exception notification emails when there's a problem

Anything that you think we're missing?

@sagepe
Copy link
Member

sagepe commented Jul 2, 2018

If I understand this ticket properly then I think it's covered for now, although we're not yet alerting directly on the metrics we're gathering just yet.

@garethrees
Copy link
Member Author

garethrees commented Jul 5, 2018

Yeah, that's fine for now I think.

Could you update the wiki page with the basic flow of where these are going (I guess something like /health/metrics → collector process → ? → ?`) and how to view them over time?

@sagepe
Copy link
Member

sagepe commented Jul 31, 2018

I've added some basic note to the FOIfC wiki page with a link to the outline of how the discovery works on the Prometheus page - do you want any more detail than this for now?

@garethrees
Copy link
Member Author

Perfect, thanks! Its more just a note that "this exists and this is roughly what's happening". It can be expanded further if/when there are specific questions that aren't answered by the wiki.

And with that, this is done! 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants