-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support syncing non-utf8 files #46
Comments
I've noticed this too. Will look into it. |
Seems to be an issue with how Brackets handles non utf-8 encodings. Waiting on adobe/brackets#13518 |
Binary has no built-in binary file support, so I've moved to Node.js. Unfortunately this means we need to do an "initial write" with a different API (as Node can't do the replaceRanges that Brackets can). YJS is being tricky about this, so it'll take some time. :/ |
Some major changes are needed to add this "dual file type" syncing. It all feels very hacky and I'm seeing a lot of issues so I'd prefer to wait until Brackets supports binary files natively. The next version will just ignore non-utf8 files. (They won't be synced). I don't think this will be that big of an issue, since you can't really "collaborate" on an image. |
@rationalcoding That's unfortunate. I was actually going to suggest just ignoring non-utf8 files until then. |
There is a new release of Brackets coming soon that updates the appshell, hopefully that fixes it. |
Brackets improved their support in I'm going to close this, since this proves any remaining errors are Bracket's fault. |
Non-text files such as images and fonts get corrupted on sync. Not sure if this is expected. Perhaps if it can't handle non-text files then it shouldn't attempt to sync them at all rather than corrupting them.
The text was updated successfully, but these errors were encountered: