Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support syncing non-utf8 files #46

Open
siphomateke opened this issue Jun 9, 2017 · 7 comments
Open

Support syncing non-utf8 files #46

siphomateke opened this issue Jun 9, 2017 · 7 comments

Comments

@siphomateke
Copy link
Contributor

Non-text files such as images and fonts get corrupted on sync. Not sure if this is expected. Perhaps if it can't handle non-text files then it shouldn't attempt to sync them at all rather than corrupting them.

@t-mullen
Copy link
Member

t-mullen commented Jun 9, 2017

I've noticed this too. Will look into it.

@t-mullen t-mullen added the bug label Jun 9, 2017
@t-mullen
Copy link
Member

t-mullen commented Jul 4, 2017

Seems to be an issue with how Brackets handles non utf-8 encodings. Waiting on adobe/brackets#13518

@t-mullen
Copy link
Member

t-mullen commented Jul 9, 2017

Binary has no built-in binary file support, so I've moved to Node.js. Unfortunately this means we need to do an "initial write" with a different API (as Node can't do the replaceRanges that Brackets can). YJS is being tricky about this, so it'll take some time. :/

@t-mullen
Copy link
Member

Some major changes are needed to add this "dual file type" syncing. It all feels very hacky and I'm seeing a lot of issues so I'd prefer to wait until Brackets supports binary files natively.

The next version will just ignore non-utf8 files. (They won't be synced). I don't think this will be that big of an issue, since you can't really "collaborate" on an image.

@siphomateke
Copy link
Contributor Author

@rationalcoding That's unfortunate. I was actually going to suggest just ignoring non-utf8 files until then.

@t-mullen t-mullen reopened this Jul 10, 2017
@t-mullen t-mullen changed the title Non-text files get corrupted Non-text files cannot be synced Jul 10, 2017
@t-mullen t-mullen changed the title Non-text files cannot be synced Support syncing non-text files Jul 10, 2017
@t-mullen
Copy link
Member

There is a new release of Brackets coming soon that updates the appshell, hopefully that fixes it.

@t-mullen t-mullen changed the title Support syncing non-text files Support syncing non-utf8 files Jul 11, 2017
@t-mullen
Copy link
Member

t-mullen commented Sep 14, 2017

Brackets improved their support in 1.10, so most files sync normally now. I still get a few "Unsupported Encoding" errors around .ico files, but for the most part things seem to be working (jpegs, pngs, fonts...)

I'm going to close this, since this proves any remaining errors are Bracket's fault.

@t-mullen t-mullen reopened this Oct 25, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants