Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Duplicating files #43

Open
siphomateke opened this issue Jun 1, 2017 · 4 comments
Open

Duplicating files #43

siphomateke opened this issue Jun 1, 2017 · 4 comments
Labels

Comments

@siphomateke
Copy link
Contributor

Issue
After hosting from computer1 with some files, connecting to multihack-server from computer2, which doesn't have any files, computer1 will receive the files (it already has) again duplicating everything within them. So if it has one line, after syncing it will have the same line again below the first.

Steps to reproduce

  1. start a multihack-server
  2. create files on computer1 and join a room
  3. open an empty folder on computer2
  4. connect to the same room as computer1 from computer2

Expected result
The files sync successfully onto computer2 but not onto computer1 since it is the one providing them. computer1 should not experience any changes to it's files after syncing.

@t-mullen
Copy link
Member

t-mullen commented Jun 1, 2017

This is another example of merge conflicts when there are different versions being synced.

@t-mullen t-mullen closed this as completed Jun 1, 2017
@t-mullen t-mullen reopened this Jun 1, 2017
@t-mullen t-mullen closed this as completed Jun 1, 2017
@t-mullen
Copy link
Member

t-mullen commented Jun 1, 2017

That does seem different from what normally happens though, I think this is related to your other issue.

@t-mullen
Copy link
Member

t-mullen commented Jun 4, 2017

Some events were leaking through as changes. Fixed next version.

@t-mullen
Copy link
Member

t-mullen commented Jun 4, 2017

Fixed in 4.2.0

@t-mullen t-mullen closed this as completed Jun 4, 2017
@t-mullen t-mullen reopened this Oct 25, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants