Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

B6 review #17

Open
mukul0596 opened this issue Jan 3, 2019 · 2 comments
Open

B6 review #17

mukul0596 opened this issue Jan 3, 2019 · 2 comments
Assignees
@sarthak-sehgal @kunal-mohta @LakshSingla

Comments

@mukul0596
Copy link
Owner

No description provided.

@kunal-mohta
Copy link
Collaborator

Make it a habit to indent your code properly, like here and here.
Other than that, this works fine.

@kunal-mohta
Copy link
Collaborator

Also, please don't re-declare variables - here
Instead declare var i once outside the if block and then do the assignments.

@kunal-mohta kunal-mohta reopened this Jan 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sarthak-sehgal sarthak-sehgal

@kunal-mohta kunal-mohta

@LakshSingla LakshSingla

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@sarthak-sehgal @kunal-mohta @LakshSingla @mukul0596