-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
hubot ^3.0.0 and hubot-test-helper in JS ES2015 #47
Comments
@cirpo Hi, thank you for letting me know! It's also welcome to send another PR to re-write when you've done all of TODOs written in the description of the PR! (#49 (comment)) |
@mtsmfm shall I send PR on the es2015 branch? How do you want to manage it? |
and, what do you think about using jest instead of mocha? |
Sending PR on the es2015 branch is preferable. Normally I can't work a lot on this repo on a weekday so creating completely another one is also ok if your branch has completed the TODOs. |
It sounds interesting but please don't mix with this issue 🙏 I only know the name "jest" and haven't tried yet so I'm very happy if you create another issue and tell me pros-cons on the created issue. |
@mtsmfm sure, in my opinion, we could use this issue for discussions around porting this awesome lib in this issue. I would avoid having several discussion all over the place, what do you think? |
I will wait for the next weekend, otherwise we will both do the same thing at the same time. |
If a topic should be done with the porting (eg. changing usage), of course it should be discussed in this issue. But using jest instead of mocha can be done without porting, so I asked you to create another issue 🙏 |
Will do then, thanks 🙌
On Sun, 1 Oct 2017 at 9:48 am, Fumiaki MATSUSHIMA ***@***.***> wrote:
in my opinion, we could use this issue for discussions around porting this
awesome lib in this issue. I would avoid having several discussion all over
the place, what do you think?
If a topic should be done with the porting (eg. usage), of course it
should be discussed in this issue.
But using jest instead of mocha can be done without porting, so I asked
you to create another issue 🙏
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#47 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AADINKUIwqzK9rhZO_bj1iA8sSQF2DpGks5sn1HPgaJpZM4PiCVJ>
.
--
@cirpo
mobile: +44 7492 014 290
skype: cirpolo
linkedin: http://linkedin.com/in/cinellialessandro
github: http://github.com/cirpo
|
@cirpo I've just finished and released! |
@mtsmfm congrats, I'll have a look and send PRs if needed, thanks |
Hi, I'm in the process of writing hubot-test-helper in JavaScript instead of CoffeeScript and support the new Hubot 3.0.0 release which is entirely re-written in JavaScript (ES2015).
Before opening a new repo/npm package I would like to know if you're already working on a pure JavaScript version for this (awesome) helper in order to avoid wasting time and help you with it.
Let me know, thanks
The text was updated successfully, but these errors were encountered: