Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hubot ^3.0.0 and hubot-test-helper in JS ES2015 #47

Closed
cirpo opened this issue Sep 24, 2017 · 11 comments
Closed

hubot ^3.0.0 and hubot-test-helper in JS ES2015 #47

cirpo opened this issue Sep 24, 2017 · 11 comments

Comments

@cirpo
Copy link

cirpo commented Sep 24, 2017

Hi, I'm in the process of writing hubot-test-helper in JavaScript instead of CoffeeScript and support the new Hubot 3.0.0 release which is entirely re-written in JavaScript (ES2015).

Before opening a new repo/npm package I would like to know if you're already working on a pure JavaScript version for this (awesome) helper in order to avoid wasting time and help you with it.

Let me know, thanks

@mtsmfm mtsmfm mentioned this issue Sep 30, 2017
5 tasks
@mtsmfm
Copy link
Owner

mtsmfm commented Sep 30, 2017

@cirpo Hi, thank you for letting me know!
I just start re-writing, however, it may take a while.

It's also welcome to send another PR to re-write when you've done all of TODOs written in the description of the PR! (#49 (comment))

@cirpo
Copy link
Author

cirpo commented Sep 30, 2017

@mtsmfm shall I send PR on the es2015 branch? How do you want to manage it?

@cirpo
Copy link
Author

cirpo commented Sep 30, 2017

and, what do you think about using jest instead of mocha?

@mtsmfm
Copy link
Owner

mtsmfm commented Oct 1, 2017

shall I send PR on the es2015 branch? How do you want to manage it?

Sending PR on the es2015 branch is preferable.
Hopefully, I'll finish this task by next weekend so please be patient if you can wait a while.

Normally I can't work a lot on this repo on a weekday so creating completely another one is also ok if your branch has completed the TODOs.

@mtsmfm
Copy link
Owner

mtsmfm commented Oct 1, 2017

and, what do you think about using jest instead of mocha?

It sounds interesting but please don't mix with this issue 🙏

I only know the name "jest" and haven't tried yet so I'm very happy if you create another issue and tell me pros-cons on the created issue.

@cirpo
Copy link
Author

cirpo commented Oct 1, 2017

@mtsmfm sure, in my opinion, we could use this issue for discussions around porting this awesome lib in this issue. I would avoid having several discussion all over the place, what do you think?
For example hubot documented and discussed everything in this issue: hubotio/evolution#4

@cirpo
Copy link
Author

cirpo commented Oct 1, 2017

I will wait for the next weekend, otherwise we will both do the same thing at the same time.

@mtsmfm
Copy link
Owner

mtsmfm commented Oct 1, 2017

in my opinion, we could use this issue for discussions around porting this awesome lib in this issue. I would avoid having several discussion all over the place, what do you think?

If a topic should be done with the porting (eg. changing usage), of course it should be discussed in this issue.

But using jest instead of mocha can be done without porting, so I asked you to create another issue 🙏

@cirpo
Copy link
Author

cirpo commented Oct 1, 2017 via email

@mtsmfm
Copy link
Owner

mtsmfm commented Oct 8, 2017

@cirpo I've just finished and released!

@mtsmfm mtsmfm closed this as completed Oct 8, 2017
@cirpo
Copy link
Author

cirpo commented Oct 9, 2017

@mtsmfm congrats, I'll have a look and send PRs if needed, thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants