Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Possible install documentation update required #197

Open
maxinelasp opened this issue Oct 17, 2024 · 1 comment
Open

Possible install documentation update required #197

maxinelasp opened this issue Oct 17, 2024 · 1 comment

Comments

@maxinelasp
Copy link

Hi, we're using poetry-dynamic-versioning in our Github repo and finding that it works quite well.

However, we recently encountered an issue where someone new was trying to install the plugin using poetry self add "poetry-dynamic-versioning[plugin]", as recommended in the README, but he got the error Could not find a matching version of package “poetry-dynamic-versioning[plugin]”. I looked through the Poetry docs, suggested running poetry self add poetry-dynamic-versioning and that worked fine.

So, I wanted to suggest updating the readme in this repo to follow that Poetry standard instead. I'm happy to open a PR for that change, but I wanted to see if I was missing something with the difference between the two install commands.

Thanks for the plugin, it's a good fix for a missing piece in Poetry.

@mtkennerly
Copy link
Owner

Hi! Could you tell me which version of Poetry they're using and how they installed it (pip, pipx, etc)? And although the install worked, is the plugin actually activating when they run poetry build or other commands?

The [plugin] format specifies an "extra". It's covered in the Poetry docs here: https://python-poetry.org/docs/cli/#add

image

I'm using Poetry 1.8.3 installed by pipx on Windows, and it works on my end:

$ poetry self add "poetry-dynamic-versioning[plugin]"
Using version ^1.4.1 for poetry-dynamic-versioning

Updating dependencies
Resolving dependencies... (0.4s)

Package operations: 4 installs, 0 updates, 0 removals

  - Installing markupsafe (3.0.2)
  - Installing dunamai (1.22.0)
  - Installing jinja2 (3.1.4)
  - Installing poetry-dynamic-versioning (1.4.1)

Writing lock file

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants