Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve tests #249

Open
S-S-X opened this issue Nov 23, 2021 · 0 comments
Open

Improve tests #249

S-S-X opened this issue Nov 23, 2021 · 0 comments
Labels
Enhancement New feature or request

Comments

@S-S-X
Copy link
Member

S-S-X commented Nov 23, 2021

Few things to change:

Move solar arrays higher

Some networks use solar arrays and are placed to y=1, move these bit higher near y=50 or so and reduce total count of solar arrays.
This should reduce "background noise" for tests and is not really useful for testing.
If solar arrays need testing then new spec should be added for those, for other tests those are just components to allow testing...

Just moving solar arrays higher can reduce required node count significantly, this might not sound like big thing but it is.

Better readability for world layout

Use world.layout where possible (instead of world.place_node) to reduce world setup loops and give cable positions as area for example {{x=0,y=50,z=0},{x=0,y=50,z=100}}.
Remember that world.layout does clear existing world, consider world.add_layout if needed.

Assertions and argument order

In assertions move expected value to left side and actual value to right side where possible (to get more understandable failure messages).
Fun fact: these been mixed up even in luassert sources so there might actually be assertions that wont follow this... but I think most do

@BuckarooBanzay BuckarooBanzay added the Enhancement New feature or request label Nov 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants