Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add public registration API for Technic chests #231

Open
6 tasks
S-S-X opened this issue Oct 29, 2021 · 2 comments
Open
6 tasks

Add public registration API for Technic chests #231

S-S-X opened this issue Oct 29, 2021 · 2 comments
Labels
Enhancement New feature or request

Comments

@S-S-X
Copy link
Member

S-S-X commented Oct 29, 2021

See #117 and #117 (comment)

PR that updated registration to provide basic usable API is merged.

Things to do:

  • Allow overriding functions.
  • Allow overriding other fields.
  • Also allow adding fields not known by technic_chests.
  • See if there's existing functions that would be useful if exported to public API and add those.
    For example to be used when overriding some of default functions.
  • Configuration for default chest registrations, select features and disable chest types.
  • After this list is completed this should probably be standalone mod not included with technic modpack...
@S-S-X S-S-X added the Enhancement New feature or request label Oct 29, 2021
@OgelGames
Copy link
Contributor

An issue really isn't needed when a PR to fix it is created at the same time...

@S-S-X
Copy link
Member Author

S-S-X commented Nov 4, 2021

An issue really isn't needed when a PR to fix it is created at the same time...

Like stated also on linked PR "API is not complete but more like starting point" pull request linked here is far from complete implementation, more is needed to make it complete.
It is also different from #117 and that issue has separate PR which is supposed to close it.

I think it is good to have issue as a reminder after linked PR is closed.
edit. should also remove closing keyword, will update that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants