Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Give faction owners the power to force-join (invite) players. #9

Open
SwissalpS opened this issue Sep 14, 2024 · 3 comments
Open

Give faction owners the power to force-join (invite) players. #9

SwissalpS opened this issue Sep 14, 2024 · 3 comments
Labels
enhancement New feature or request

Comments

@SwissalpS
Copy link
Contributor

As of now, only faction admins can force-join (invite) players to factions. Owners or faction members have to give new potential members the password and ask them to join.
This is mostly fine until a new/potential member starts publishing the password without consent of the owner.

The system would have to work similar to /tpr and /tphr do. Invited player should have the opportunity to decline. Not only for better UX but also because there is a catch:
[protector] only checks if player is in at least one same faction as owner. Since [protector] only uses a boolean flag to allow factions and doesn't keep a list of them.

So if player B has a protector that has faction support enabled, and so far player B is using that for the only faction FB that he is a member of.
Now if player C has a faction, FC, and force-joins player B to it, this gives all players of FC access to player B's protector area.

What do you think, is this worth hashing out a solution to or do we just leave things as they are?

@S-S-X
Copy link
Member

S-S-X commented Sep 14, 2024

Good but only if invitee can refuse invitation, basically that would be requirement for explicit accept so very similar to those teleport request commands when used without admin privs.

@S-S-X
Copy link
Member

S-S-X commented Sep 14, 2024

Also members probably should not have ability to invite others but there could be multiple owners / shared ownership, shouldn't be that complicated and allows a lot more fine grained control of factions.

@SwissalpS
Copy link
Contributor Author

If 'moderators' (shared ownership) field is added, might as well add a field for short description of faction. Might help both members and owners remember what the idea of the faction is.

@BuckarooBanzay BuckarooBanzay added the enhancement New feature or request label Sep 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants