-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update mirror link + rebase on upstream #6
Comments
Note that if rebasing to https://leagueh.xyz/git/playerfactions.git or merging any changes done on upstream after 40f6f212 then license will be updated to AGPL while licence obtained for this fork is GPLv3. Commits we have under GPLv3 license:77fe095 (HEAD -> master, origin/master, origin/HEAD) nil check patch (#5) Commits done to leagueh.xyz, at least last two being under AGPL license:7e2b190 (leagueh/main) General fixes Note that this creates problem because AGPL is not compatible with GPL. Following copyright strictly makes this complicated but I guess changes here can be merged to upstream assuming that contributors who used GPLv3 will not complain. I am basically recommending against any merges between repositories before it is clear what other troubles AGPL can cause. edit. Removed mirror link for now as this is not really mirror currently, link should be corrected and restored either as mirror-of or some kind of based-on-commit link depending on decisions about merging or rejecting license updates. |
Oh, you are right. If it is too complicated, nevermind… However commits since the fork seems almost trivial (no new feature, only bug-fixes and workflow), so as long as paternity of commit is preserved (this can be done in a merge commit) re-licensing to AGPLv3 may imo not cause any trouble (of course it is best if we had each contributor's agreement). |
Hi, could you please update mirror link in the "about" section of the repository to https://leagueh.xyz/git/playerfactions/? The
git
subdomain doesn't exist anymore and this is annoying.Also, maybe we could rebase the mirror to get the same commit history on the mirror than on upstream (this would make easier to know if the mirror is up-to-date) while preserving local patches.
The text was updated successfully, but these errors were encountered: