'Cannot read properties of undefined (reading 'url')' when multiple browser tabs are open

[vik-buchinski]

Prerequisites

• I confirm my issue is not in the opened issues
• I confirm the Frequently Asked Questions didn't contain the answer to my issue

Environment check

• I'm using the latest msw version
• I'm using Node.js version 18 or higher

Browsers

Chromium (Chrome, Brave, etc.)

Reproduction repository

https://github.com/hal-shin/msw-bug

Reproduction steps

1. install nodejs v20.12.2
2. npm i
3. npm start
4. open 2 tabs 'http://localhost:3000/'
5. after opening the second tab, you'll see the following error:

Current behavior

when the second tab opened, I see 'Cannot read properties of undefined (reading 'url')' error.

Affected versions: >2.1.7
Versions that work correctly: <= 2.1.7

Expected behavior

application should continue working when it is opened in 2 tabs.

[akumapps]

Same behavior here with version 2.3.0

[kaique64]

I got the same behavior here with version 2.3.0

[gypz24]

I got the same result

[ByteWither]

@kettanaito Hi! I find this PR #2031. I think it is a reason of this bug. Can you fix it?
Also, I still get error with version 2.3.1 :(

[PedroBarbosaSw]

Any update regarding this issue?

[Crauzer]

This is also happening on the latest version 2.4.11, when multiple tabs of the same origin are open, this error shows up once for each open tab.

The service worker also crashes when you reload the page multiple times:

[Marcosld]

We are having this problem in our project. It breaks our screenshot/acceptance tests :(

[diego-aquino]

I can confirm that this issue is still happening in [email protected], using the same reproduction created by @vik-buchinski.

---

It looks like request is getting undefined and line 58 throws:

msw/src/browser/setupWorker/start/createResponseListener.ts

Lines 56 to 61 in 9dc2d71

	if (!response.url) {
	Object.defineProperty(response, 'url', {
	value: request.url,
	enumerable: true,
	writable: false,
	})

request comes from a map and in fact can be undefined, but the code uses a non-null assertion (!).

msw/src/browser/setupWorker/start/createResponseListener.ts

Line 21 in 9dc2d71

const request = context.requests.get(requestId)!

I have no deep knowledge of this function, but maybe msw needs to check if request exists before using it?