Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Py graded ores are not supported #47

Open
logisticsbot opened this issue Jun 1, 2023 · 1 comment · May be fixed by #48
Open

Py graded ores are not supported #47

logisticsbot opened this issue Jun 1, 2023 · 1 comment · May be fixed by #48

Comments

@logisticsbot
Copy link

Hi, firstly many thanks for sharing your mod, it is great!

One minor issue that I am having is that the "graded" ores in pyrawores are not classified as ores, and only work if the mod settings are changed to allow any item.

This seems to be due to a bad pattern "^(low%-|high%-)grade%-" in bulk.lua. Unfortunately lua string.find does not support alternatives with this pipe syntax, and there are some graded ores that do not have a "high-" or "low-" prefix that I think should also be matched.

Changing this to match on the prefixes grade-, low-grade- and high-grade- individually seems to fix the issue for me locally and I think would be useful for other Py players, so I'll raise this fix as a PR for your consideration. Thanks!

@logisticsbot logisticsbot linked a pull request Jun 1, 2023 that will close this issue
@logisticsbot
Copy link
Author

I have since found that antimony ores from pyAE do not fit this pattern, since they use sb-grade- as a prefix. Relaxing the above to match either grade- (at the start) or -grade- (anywhere) resolves this and is hopefully also more future-proof!

I have updated the PR #48 to use just these two matches. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant