-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
First frame of video does not seem to adhere to frame rate #14615
Comments
This happens because ffmpeg inserts a bogus audio track when you generate the final mp4, you can add Although we shouldn't skip the first frame even if the bogus audio track exists, so this is indeed a mpv bug. |
Thanks for confirming. FYI, the issue happens with an actual (any) audio file too. A silent audio file was just used for simplicity. (It's a good thing if the bogus track uncovered another/broader issue, leading to a more resilient fix.) |
while still rejecting the case where we're delaying audio start and audio_status is at STATUS_READY. Prior art: cb2b579 (reverted in b0e6ac3) However, the general idea of the original commit was correct and the only edgecase we need to handle is audio_status being stuck at STATUS_READY in the case where audio starts after the video. Also fixes mpv-player#14615
Thanks for the quick pounce. The two patches do indeed improve the issue. However, the first frame seems to display somewhat longer than expected (about 4 seconds), as opposed to the 3 expected seconds in subsequent frames. |
Waiting for audio_started to be set to true takes too long which causes us to miss it for the first frame, instead invert the condition so it's set on the first frame. Fixes mpv-player#14615
Waiting for audio_started to be set to true takes too long which causes us to miss it for the first frame, instead invert the condition so it's set on the first frame. Fixes mpv-player#14615
Waiting for audio_started to be set to true takes too long which causes us to miss it for the first frame, instead invert the condition so it's set on the first frame. Fixes mpv-player#14615
By all accounts, e06e9c3 consistently displays each frame, including the first, for the expected 3 seconds. Well done! |
Waiting for audio_started to be set to true takes too long which causes us to miss it for the first frame, instead invert the condition so it's set on the first frame. Fixes mpv-player#14615
mpv Information
Other Information
Reproduction Steps
Mux any set of still pictures with any/silent audio as follows:
Expected Behavior
Each still picture should be shown for three seconds. It does in QuickTime.
Actual Behavior
The first still is shown for one frame only, with error message below. Subsequent stills are shown correctly (3 secs each).
If rewinding the video back to start, the first still is shown for 3 secs as expected.
If using a higher frame rate, the error message disappears, but the first frame is still rushed.
Log File
out.log
Sample Files
No response
I carefully read all instruction and confirm that I did the following:
--log-file=output.txt
.The text was updated successfully, but these errors were encountered: