From 61376a65728fb7e5736e99c52f17bb4a5ef06b29 Mon Sep 17 00:00:00 2001 From: Raphael Pierzina Date: Thu, 25 Nov 2021 18:05:50 +0100 Subject: [PATCH] Update burnham sensors (#1427) * Update minimum count of rows for burnham sensors * Add code comments to burnham sensors --- dags/burnham.py | 22 ++++++++++++++++++++-- 1 file changed, 20 insertions(+), 2 deletions(-) diff --git a/dags/burnham.py b/dags/burnham.py index 093c3efbc..c51612f5b 100644 --- a/dags/burnham.py +++ b/dags/burnham.py @@ -718,6 +718,12 @@ def sleep_task(minutes, task_id): sql=SENSOR_TEMPLATE.format( project_id=PROJECT_ID, table="discovery_v1", + # client1 sends 2 discovery pings + # client2 sends 6 discovery pings + # client3 sends 2 discovery pings + # client5 sends 2 discovery pings + # client6 sends 6 discovery pings + # client7 sends 2 discovery pings min_count_rows=20, start_timestamp=start_timestamp, test_run=burnham_test_run, @@ -776,7 +782,9 @@ def sleep_task(minutes, task_id): sql=SENSOR_TEMPLATE.format( project_id=PROJECT_ID, table="starbase46_v1", - min_count_rows=1, + # client2 sends 1 starbase46 ping + # client6 sends 1 starbase46 ping + min_count_rows=2, start_timestamp=start_timestamp, test_run=burnham_test_run, test_name=DEFAULT_TEST_NAME, @@ -819,7 +827,13 @@ def sleep_task(minutes, task_id): sql=SENSOR_TEMPLATE.format( project_id=PROJECT_ID, table="space_ship_ready_v1", - min_count_rows=5, + # client1 sends 1 space_ship_ready ping + # client2 sends 1 space_ship_ready ping + # client3 sends 1 space_ship_ready ping + # client5 sends 1 space_ship_ready ping + # client6 sends 1 space_ship_ready ping + # client7 sends 1 space_ship_ready ping + min_count_rows=6, start_timestamp=start_timestamp, test_run=burnham_test_run, test_name=DEFAULT_TEST_NAME, @@ -861,6 +875,8 @@ def sleep_task(minutes, task_id): sql=SENSOR_TEMPLATE.format( project_id=PROJECT_ID, table="discovery_v1", + # client4 sends 3 discovery pings + # client8 sends 3 discovery pings min_count_rows=6, start_timestamp=start_timestamp, test_run=burnham_test_run, @@ -904,6 +920,8 @@ def sleep_task(minutes, task_id): sql=SENSOR_TEMPLATE.format( project_id=PROJECT_ID, table="deletion_request_v1", + # client4 sends 1 deletion_request ping + # client8 sends 1 deletion_request ping min_count_rows=2, start_timestamp=start_timestamp, test_run=burnham_test_run,