Skip to content
This repository has been archived by the owner on Jun 29, 2018. It is now read-only.

YouTube player start-pause causes issues with start position #452

Open
cvcmatthewmorgan opened this issue Jun 29, 2015 · 0 comments
Open

Comments

@cvcmatthewmorgan
Copy link

I understand that this might be a continuation to #430 but I felt this was a separate issue to do with the same section of code.

I am happy to contribute a pull request to fix the issue along with #430 but would like to discuss workflow here first.

Given the use of the following code, the start time is ignored.

document.addEventListener("DOMContentLoaded", function() {
  var popcorn = Popcorn.smart("#video", "http://www.youtube.com/watch?v=eTKs27KcL00&t=10s");
}, false);

In the middle of onFirstPlay() there is a line that resets the video back to 0 which causes this to occur.

Suggested changes:

  • onFirstPlay() makes use of the start or t player variables instead of always going to 0.
  • onFirstPlay() should be triggered if player.seekTo() is going to be triggered or if preload() is required.
  • onFirstPlay() should not pause if autoplay is true.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant