Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(cirrus): Update user id to nimbus user id #11876

Closed
wants to merge 5 commits into from
Closed

feat(cirrus): Update user id to nimbus user id #11876

wants to merge 5 commits into from

Conversation

yashikakhurana
Copy link
Contributor

Because

  • To avoid naming confusion for the integrating web application, we are changing the name of field user_id to nimbus_user_id

This commit

  • Rename the field and update the test case

Fixes #11812
Note: Will also update this in the enrollment query

@yashikakhurana
Copy link
Contributor Author

Blocked on #11860

@yashikakhurana yashikakhurana mentioned this pull request Dec 3, 2024
Open
@yashikakhurana
Copy link
Contributor Author

closing this too, will open a new one with the V2 version

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jaredlockhart jaredlockhart Awaiting requested review from jaredlockhart jaredlockhart is a code owner

@jeddai jeddai Awaiting requested review from jeddai jeddai is a code owner

Assignees
No one assigned
Labels
Blocked
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Change cirrus user_id to nimbus_user_id
1 participant
@yashikakhurana