Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

warning: implicit conversion from 'int' to 'float' changes value from 2147483647 to 2147483648 #633

Open
cpeterso opened this issue Dec 20, 2020 · 2 comments

Comments

@cpeterso
Copy link
Contributor

clang version 11.0.0 warning:

media/libcubeb/src/cubeb_mixer.cpp:336:14 [-Wimplicit-const-int-float-conversion] implicit conversion from 'int' to 'float' changes value from 2147483647 to 2147483648

maxval = INT_MAX;

@ChunMinChang
Copy link
Member

I guess this can be fixed easily in cubeb_mixer.cpp. However, it seems a good opportunity to replace the old mixer code by the new audio-mixer in Windows and Linux backends. We've run it in macOS (Rust) backend for a long time and the C API is ready.

@cpeterso
Copy link
Contributor Author

it seems a good opportunity to replace the old mixer code by the new audio-mixer in Windows and Linux backends. We've run it in macOS (Rust) backend for a long time and the C API is ready.

I forgot to mention that I'm building Firefox on macOS.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants