Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

switch signers to use io.FS abstraction #787

Open
g-k opened this issue Oct 7, 2021 · 0 comments
Open

switch signers to use io.FS abstraction #787

g-k opened this issue Oct 7, 2021 · 0 comments
Labels
code quality code improvements and tidiness

Comments

@g-k
Copy link
Contributor

g-k commented Oct 7, 2021

AJ asked in #782 (comment):

Is there verification of os.RemoveAll() running successfully within SignFiles?

and we don't test the side effects of signers that read and write to disk and S3.

It's important to test this to ensure the correctness of the apk2 and gpg2 signers that shell out and the contentsignaturepki signer that writes to S3.

Switching the signers to take generic reader and writer clients and operate on an io.FS implementation might make this easier. For example by embedding an input test fixture FS then diffing it against the output FS or recording operations on a mock FS implementation.

@g-k g-k added the code quality code improvements and tidiness label Oct 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code quality code improvements and tidiness
Projects
None yet
Development

No branches or pull requests

1 participant