Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update CoT test data with modern task definitions #517

Open
ahal opened this issue Sep 2, 2021 · 0 comments
Open

Update CoT test data with modern task definitions #517

ahal opened this issue Sep 2, 2021 · 0 comments

Comments

@ahal
Copy link
Contributor

ahal commented Sep 2, 2021

The test data being used was generated a long time ago (circa cotv2 and cotv4). To help ensure the tests are relevant we should update the definitions with those from recent tasks.

I'm no expert in this regard, but I think the approach I would take is:

  1. Create tests/data/cotv7 (and add associated constants / helper methods to test_cot_verify.py)
  2. Save modern task definitions there (e.g, decision task, actions.yml, etc)
  3. Attempt to convert as many tests over to this new data as possible
  4. Remove cotv2 and cotv4 dirs. It might be fine for some tests to continue using the older data, but having a single data dir would simplify things...
  5. Verify no loss in code coverage.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant