Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

calculate reclaim_interval based on takenUntil #424

Open
escapewindow opened this issue Jan 21, 2020 · 2 comments
Open

calculate reclaim_interval based on takenUntil #424

escapewindow opened this issue Jan 21, 2020 · 2 comments

Comments

@escapewindow
Copy link
Contributor

Currently we have a fixed reclaim_interval seconds. In this thread, Tom's suggesting we should follow docker- and generic-worker's examples in calculating when to reclaim, using on some decimal multiplier or seconds before takenUntil.

When we do this, we should also look into modifying the notarization-poller in scriptworker-scripts.

@escapewindow
Copy link
Contributor Author

We should take bug 1611255 into account if/when we do this. Our current approach doesn't run as much risk of accidental claim-expired.

@escapewindow
Copy link
Contributor Author

Aiui, we went with 5 minutes hardcoded because a) it's simpler than calculating against takenUntil, b) unless takenUntil changes significantly, it's less likely to hit claimExpired due to slow reclaims, and c) scriptworkers have thus far been significantly smaller in quantity than our docker- and generic-worker pools. I'm leaning towards leaving it, but leaving this issue open in case we want to revisit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant