Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

non-verbose scriptworker should work #341

Open
escapewindow opened this issue Jun 4, 2019 · 3 comments
Open

non-verbose scriptworker should work #341

escapewindow opened this issue Jun 4, 2019 · 3 comments

Comments

@escapewindow
Copy link
Contributor

In mozilla-releng/build-puppet#498, I turned off signing scriptworker's verbosity for both the script and daemon. This broke two things:

  • scriptworker doesn't log to the screen if verbose is False. This means scriptworker logs stop going to papertrail
  • nagios relies on the worker.log being up to date to see if the daemon is alive. If the daemon is alive but idle for a long period of time with verbose set to False, the log ages past the warning age.

I turned verbose back on for the daemon in mozilla-releng/build-puppet#500. However, we shouldn't have to keep the daemon verbose.

We should:

  • separate log level from screen output in the config, so we can set the log level to INFO but keep console output for papertrail. (Or, we can add worker.log to the syslog config.)

  • do something to avoid triggering nagios if the log level is higher than DEBUG:

    • claimWork at the INFO level
    • output an occasional scriptworker is still alive every half hour or so if we've been idle
    • stop monitoring worker.log in nagios since we haven't really had an issue with hung scriptworker daemons for a long time
@nthomas-mozilla
Copy link
Contributor

We can also filter away logs at papertrail so they don't count against against log transfer. Should be able to drop DEBUG there while leaving the nagios check unaffected.

@escapewindow
Copy link
Contributor Author

++, let's do this for all scriptworkers.

@escapewindow
Copy link
Contributor Author

This is probably still an issue for the mac signers. We may want to doublecheck whether this is an issue on the docker images.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants