Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TimeoutError when uploading full firefox release #3126

Open
sentry-io bot opened this issue Jul 8, 2024 · 6 comments
Open

TimeoutError when uploading full firefox release #3126

sentry-io bot opened this issue Jul 8, 2024 · 6 comments
Labels
admin admin app & api (aus4-admin.mozilla.org) python Pull requests that update Python code releases release data

Comments

@sentry-io
Copy link

sentry-io bot commented Jul 8, 2024

Sentry Issue: BALROG-STAGE-ADMIN-2Q

TimeoutError: 
(22 additional frame(s) were not displayed)
...
  File "/usr/local/lib/python3.11/site-packages/gcloud/aio/auth/token.py", line 357, in refresh
    resp = await self._refresh_service_account(timeout=timeout)
  File "/usr/local/lib/python3.11/site-packages/gcloud/aio/auth/token.py", line 322, in _refresh_service_account
    resp = await self.session.post(
  File "/usr/local/lib/python3.11/site-packages/gcloud/aio/auth/session.py", line 190, in post
    resp = await self.session.post(
  File "aiohttp/client.py", line 507, in _request
    with timer:
  File "aiohttp/helpers.py", line 735, in __exit__
    raise asyncio.TimeoutError from None
@sentry-io sentry-io bot added admin admin app & api (aus4-admin.mozilla.org) python Pull requests that update Python code releases release data labels Jul 8, 2024
Copy link
Author

sentry-io bot commented Jul 8, 2024

Sentry Issue: BALROG-STAGE-ADMIN-21

Copy link
Author

sentry-io bot commented Jul 8, 2024

Sentry Issue: BALROG-PROD-ADMIN-2T

Copy link
Author

sentry-io bot commented Jul 8, 2024

Sentry Issue: BALROG-PROD-ADMIN-2S

@jcristau
Copy link
Contributor

jcristau commented Jul 8, 2024

PUT /api/v2/releases/foo with a full firefox blob as the body fails with a 502 or 504 returned to the client, and on the server side a TimeoutError and OSError in sentry, along with lots of "Giving up acquire_access_token(...) after 5 tries (TimeoutError)", in gcloud auth code.

@jcristau
Copy link
Contributor

jcristau commented Jul 8, 2024

This was already happening with v3.45, seeing it today with v3.51 (prod) and v3.52 (stage).

@bhearsum
Copy link
Contributor

bhearsum commented Jul 8, 2024

I finally managed to dig up #1249 (comment), which was where async uploading was added. Most notably there is this comment:

In my local testing, I was able to create a Release with ~550 locales in less than 10 seconds. Without this patch, creating a Release with only 16 locales took around 15 seconds.

There's also an idea about a more ideal solution:

A more ideal solution would probably invole writing entries to the database as part of the http request, and having the Balrog Agent handle the GCS side of things -- but that's a more involved project.

(I looked but I couldn't find a bug report that necessitated this PR.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
admin admin app & api (aus4-admin.mozilla.org) python Pull requests that update Python code releases release data
Projects
None yet
Development

No branches or pull requests

2 participants