Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot change an aliased rule anymore: "rule with alias exists" #3048

Closed
JohanLorenzo opened this issue Nov 10, 2023 · 2 comments · Fixed by #3049
Closed

Cannot change an aliased rule anymore: "rule with alias exists" #3048

JohanLorenzo opened this issue Nov 10, 2023 · 2 comments · Fixed by #3049
Labels
admin admin app & api (aus4-admin.mozilla.org) python Pull requests that update Python code rules balrog rules and rule validation

Comments

@JohanLorenzo
Copy link
Contributor

Discovered by @wsmwk (cc @jfx2006)

Steps to reproduce

  1. Change background rate of a rule (e.g.: https://balrog.services.mozilla.com/rules/43)
  2. Submit changes

Expected result

New scheduled change is waiting for sign-offs

Actual result

UI shows error rule with alias exists

Screenshot 2023-11-10 at 10-21-51 Update Rule 43 (thunderbird-beta) - Balrog Admin

The backend returns a 400:

Screenshot 2023-11-10 at 10 22 20

Warning ⚠️

I worked around the issue by modifying the alias of the rule alongside the background rate. Now the alias is thunderbird-beta1. I wanted to change it back but I get a second error: Rule is scheduled with the given alias

image

Additional notes

It's likely a regression from #3010 (#2942). It seems no newly added error message works as expected. I believe we should likely back it out and redeploy balrog. I didn't to it for 3 reasons:

  1. The problem was worked around.
  2. I'm the only Release Engineer today. Moreover, yesterday, I noticed I don't have access to the Jenkins instance anymore. I'm waiting for SRE to get this resolved.
  3. It's a patch made by an external contributor.

@bhearsum @gabrielBusta, let me know what the best approach is to you.

@JohanLorenzo JohanLorenzo added admin admin app & api (aus4-admin.mozilla.org) rules balrog rules and rule validation python Pull requests that update Python code labels Nov 10, 2023
@JohanLorenzo
Copy link
Contributor Author

Firefox[1] and DevEdition[2] 120.0b9 were both impacted too. I worked around them with the same trick. I'm going to let the downstream tasks force-run by cancelling and rerunning them.

[1] https://balrog.services.mozilla.com/rules?product=Firefox&channel=beta#scId=5467
[2] https://balrog.services.mozilla.com/rules?product=Firefox&channel=aurora#scId=5468

@JohanLorenzo
Copy link
Contributor Author

Bug 1864286 was also put on file.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
admin admin app & api (aus4-admin.mozilla.org) python Pull requests that update Python code rules balrog rules and rule validation
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant