Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ctr-Z doesn't undo last action #15

Closed
Vilhelm-Ian opened this issue Oct 20, 2023 · 5 comments
Closed

Ctr-Z doesn't undo last action #15

Vilhelm-Ian opened this issue Oct 20, 2023 · 5 comments
Assignees

Comments

@Vilhelm-Ian
Copy link
Contributor

I pressed K on a card. And wanted to double check if I knew the word and i wasn't able with ctrl+z

@mortii
Copy link
Owner

mortii commented Oct 21, 2023

Yeah, that is the "Fix undo-review" item on the roadmap.

@mortii
Copy link
Owner

mortii commented Oct 25, 2023

I'm making good progress on this. My previous assessment (kaegi/MorphMan#302) was pessimistic, but I found an amazing ankiweb thread that has made it much easier.

One caveat is that the new undo system only works for the v3 scheduler, but that is actually a blessing in disguise because I can now stop supporting v2 and just display an error if someone is using it.

@mortii mortii changed the title Ctr-Z dosen't undoe last action Ctr-Z doesn't undo last action Oct 25, 2023
mortii added a commit that referenced this issue Oct 29, 2023
@mortii
Copy link
Owner

mortii commented Oct 29, 2023

My pessimism was warranted, fixing this was a nightmare, lol. There is a known bug I can't fix, but it should be rare enough to not cause any major problems. One thing to keep in mind is that the undo queue breaks/is reset after a recalc.

@mortii
Copy link
Owner

mortii commented Oct 29, 2023

Let me know if any other problems occur!

@mortii mortii closed this as completed Oct 29, 2023
Copy link

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 29, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants