Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve naming and group components #61

Open
4 tasks
julien-devatom opened this issue Jul 19, 2023 · 0 comments
Open
4 tasks

Improve naming and group components #61

julien-devatom opened this issue Jul 19, 2023 · 0 comments
Labels
enhancement New feature or request

Comments

@julien-devatom
Copy link
Contributor

julien-devatom commented Jul 19, 2023

Feature Request

Is your feature request related to a problem? Please describe.

To clarify the difference between all components, I suggest modifying the naming and grouping components into different categories.

Describe the solution you'd like

An extension is a class depending on an adapter. It uses an adapter to retrieve data, emit values, etc, and add some logic.
They have a clean interface, different from the adapter, and use the adapter as a read-only snapshot of the Morpho contract state. They can also subscribe to DataEmitters to update their own Observers. they cannot modify the values of the adapter.

  • BulkerTxHandler => BulkerExtension
  • MorphoAaveV3Simulator => SimulatorExtension

A service is an adapter component, for example, TxHandler or Fetcher.
They have only one responsibility. EG, the responsibility of the fetcher is only to fetch data from somewhere, and that's it.
So I suggest renaming them to stg like

  • TxHandler => TxHandlerService
  • Fetcher => FetcherService

Are you willing to resolve this issue by submitting a Pull Request?

  • Yes, I have the time, and I know how to start.
  • Yes, I have the time, but I don't know how to start. I would need guidance.
  • No, I don't have the time, although I believe I could do it if I had the time...
  • No, I don't have the time and I wouldn't even know how to start.
@julien-devatom julien-devatom added the enhancement New feature or request label Jul 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant