You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Is your feature request related to a problem? Please describe.
To clarify the difference between all components, I suggest modifying the naming and grouping components into different categories.
Describe the solution you'd like
An extension is a class depending on an adapter. It uses an adapter to retrieve data, emit values, etc, and add some logic.
They have a clean interface, different from the adapter, and use the adapter as a read-only snapshot of the Morpho contract state. They can also subscribe to DataEmitters to update their own Observers. they cannot modify the values of the adapter.
BulkerTxHandler => BulkerExtension
MorphoAaveV3Simulator => SimulatorExtension
A service is an adapter component, for example, TxHandler or Fetcher.
They have only one responsibility. EG, the responsibility of the fetcher is only to fetch data from somewhere, and that's it.
So I suggest renaming them to stg like
TxHandler => TxHandlerService
Fetcher => FetcherService
Are you willing to resolve this issue by submitting a Pull Request?
Yes, I have the time, and I know how to start.
Yes, I have the time, but I don't know how to start. I would need guidance.
No, I don't have the time, although I believe I could do it if I had the time...
No, I don't have the time and I wouldn't even know how to start.
The text was updated successfully, but these errors were encountered:
Feature Request
Is your feature request related to a problem? Please describe.
To clarify the difference between all components, I suggest modifying the naming and grouping components into different categories.
Describe the solution you'd like
An
extension
is a class depending on anadapter
. It uses an adapter to retrieve data, emit values, etc, and add some logic.They have a clean interface, different from the adapter, and use the adapter as a read-only snapshot of the Morpho contract state. They can also subscribe to DataEmitters to update their own
Observers
. they cannot modify the values of the adapter.BulkerTxHandler
=>BulkerExtension
MorphoAaveV3Simulator
=>SimulatorExtension
A
service
is anadapter
component, for example,TxHandler
orFetcher
.They have only one responsibility. EG, the responsibility of the fetcher is only to fetch data from somewhere, and that's it.
So I suggest renaming them to stg like
TxHandler
=>TxHandlerService
Fetcher
=>FetcherService
Are you willing to resolve this issue by submitting a Pull Request?
The text was updated successfully, but these errors were encountered: