-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for collection metadata when adding items to collection #143
Comments
from what I've researched, the endpoint for this exists: so it uses to_json from Movies: as you can see it restricts fields that can be taken form movie object. however, should the properties like media_type/resolution/audio/audio_channels be taken from the movie object? or parameters of add_to_library? |
also, why such inconsistency? for movies all ids are passed, for tv episodes only trakt id is passed, for movies title and year are passed as well? |
It seems like the metadata needs to be applied on a per-media item basis, so I'm thinking we probably need a new type to merge the media and the metadata fields. As for the inconsistency between the episodes and movies... I'm honestly not sure. This endpoint seems like it's changed a bit since this chunk of the code was originally written. |
I'm myself submitting the metadata separately, as it's not part of the trakt media item. As the to_json structure is not mergeable, had to rewrite whole payload on my own: |
see:
api docs:
refs:
The text was updated successfully, but these errors were encountered: