Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[chore] Attempt to link straight to same doc in different version #477

Open
andrewnicols opened this issue Dec 12, 2022 · 3 comments
Open
Labels
help wanted Extra attention is needed repo

Comments

@andrewnicols
Copy link
Member

What do we need to do?

Regarding versioned documentation, a suggestion from Eloy:

If you hover the menu (or click on the "triangle") it correctly shows you the available options (master, 4.1 and legacy). Then can select any of them, all ok. But, if you click on the "name" of the current version, then you're redirected to the "base" document in that version. IMO, that's completely unexpected. The "name" should behave the very same than the "triangle" or become 100% disabled.

@andrewnicols
Copy link
Member Author

It looks like we already do this...

Screen Shot 2022-12-12 at 12 54 14

Where are you seeing this not happen?

@stronk7
Copy link
Member

stronk7 commented Dec 12, 2022

Yep, yep, clicking on the hovered drop-down elements does send you to the correct page, so you can switch between the "Advanced Grading API" versions perfectly. That works ok.

The issue I reported was that clicking on the drop-down (name or triangle), sends you to the "base" page. And that's the behaviour I'm not sure it's 100% nice. Maybe it's only a matter of getting used for the hover to appear, but my first impulse was to go straight and click on the "name + triangle" (I didn't know that the menu was going to show automatically).

Not sure if I'm explaining it properly, heh. Just in any versioned page click on the top name or triangle. Do you think the current action (go to "base" page) is ok? As said maybe it's only a matter of getting used, just was not "natural" for me.

Ciao :-)

@andrewnicols
Copy link
Member Author

Ah thank s- I got it. I'll see what we can do

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed repo
Projects
None yet
Development

No branches or pull requests

3 participants