Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

What does this bundle offer more? #1

Open
gmponos opened this issue Aug 4, 2017 · 6 comments
Open

What does this bundle offer more? #1

gmponos opened this issue Aug 4, 2017 · 6 comments

Comments

@gmponos
Copy link
Collaborator

gmponos commented Aug 4, 2017

What does this bundle offer more?

Would you like me to add a services yml?

@sagikazarmark
Copy link
Contributor

This is going to be an official bundle once someone picks it up. There has been some promises from Sylius guys, but no work has been done so far.

@gmponos
Copy link
Collaborator Author

gmponos commented Aug 4, 2017

Would you like me to add a services yml?

@bendavies
Copy link

cc @pjedrzejewski

@gmponos
Copy link
Collaborator Author

gmponos commented Aug 18, 2017

Any news about this? I was thinking about also adding some twig functions. In order to get the money object and convert it to it's major amount.

Since no reply came I will try to commit some PR during the weekend about and see how this goes.

@gmponos
Copy link
Collaborator Author

gmponos commented Aug 23, 2017

Anyway I will try to create PR for the following:

  • Add services
    • Define Aggregator with Currencies.
    • Define Aggregator with Parsers
    • Define Aggregator with Formatters.
  • Add Dependency Injection Tags about adding
    • A parser
    • A formatter.
    • A Currency Repository.

@gmponos
Copy link
Collaborator Author

gmponos commented Nov 17, 2018

I would be interest in helping as a maintainer this package if you guys wish so...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants