Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PAT name lenght check is ignored when editing PAT (Different lenght requirements for PAT name when creating and editing) #1549

Open
JustLetterV opened this issue Aug 6, 2023 · 0 comments · May be fixed by #2906
Open

PAT name lenght check is ignored when editing PAT (Different lenght requirements for PAT name when creating and editing) #1549

JustLetterV opened this issue Aug 6, 2023 · 0 comments · May be fixed by #2906
Labels
bug Something isn't working web Relates to Modrinth.com web frontend

Comments

@JustLetterV
Copy link

Describe the bug

When creating PAT there seems to be a length requirement of 3 for the name, but it's ignored when editing PAT.

Steps to reproduce

  1. Click on the "Create a PAT" button.
  2. Try to set PAT name to 'a'.
  3. Get an error to the bottom right corner.
  4. Change the name to 'aaa' and click on the "Create PAT" button.
  5. Click on the "Edit token" button.
  6. Set the name to 'a' and then click on the "Save changes" button.
  7. Name length is ignored.

Expected behavior

The name length check shouldn't be ignored when editing.

Alternatively, the length check should be 1 character always instead of 3 when creating PAT and 1 when editing.

Additional context

No response
@JustLetterV JustLetterV added the bug Something isn't working label Aug 6, 2023
@Prospector Prospector transferred this issue from modrinth/knossos Aug 3, 2024
@Prospector Prospector added the web Relates to Modrinth.com web frontend label Aug 3, 2024
AarhamH pushed a commit to AarhamH/theseus that referenced this issue Aug 3, 2024
@darling
Add withdrawal amount validation and display details (modrinth#1549)
354bfe5 
* Add withdrawal amount validation and display transfer details

* Fixed amt should be consistent

* Empty amount rather than clamp

* Only mutate amount if fixed or 1 value

* Add badge to giftcard withdraw methods
Erb3 added a commit to Erb3-forked/modrinth that referenced this issue Nov 4, 2024
@Erb3
fix(backend): validate PAT name
a2e2927 
Uses the macros provided by validator to validate the name. The name already had a macro, but .validate was not called.

Resolves modrinth#1549
@Erb3 Erb3 linked a pull request Nov 4, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working web Relates to Modrinth.com web frontend
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(labrinth): validate PAT name Erb3-forked/modrinth
2 participants
@Prospector @JustLetterV