Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixes(Mf6Splitter): multiple bug fixes and added support #2418

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

jlarsen-usgs
Copy link
Contributor

@jlarsen-usgs jlarsen-usgs commented Jan 13, 2025

  • add support for GWE models
  • fix zero padding issue in split_multi_model. Padding issue caused splitting arrays with 10 or more model domains to crash.

Closes #2415

Copy link

codecov bot commented Jan 13, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 76.3%. Comparing base (bb9824e) to head (3ace07e).
Report is 41 commits behind head on develop.

Additional details and impacted files
@@            Coverage Diff            @@
##           develop   #2418     +/-   ##
=========================================
+ Coverage     68.4%   76.3%   +7.8%     
=========================================
  Files          294     294             
  Lines        59390   59894    +504     
=========================================
+ Hits         40652   45723   +5071     
+ Misses       18738   14171   -4567     
Files with missing lines Coverage Δ
flopy/mf6/utils/model_splitter.py 71.9% <100.0%> (+13.1%) ⬆️

... and 247 files with indirect coverage changes

… creating exchanges

* fixes issue where "multi-models" cannot be split if there are 10 or more new model domains in the splitting mask
@jlarsen-usgs jlarsen-usgs changed the title update Mf6Splitter: Add support for groundwater energy model fixes(Mf6Splitter): multiple bug fixes and added support Jan 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

does Mf6Splitter work for multilayer models?
1 participant