Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow Timeout Configuration for web_server_proxy #2752

Open
Dragoy opened this issue Jan 12, 2025 · 0 comments
Open

Allow Timeout Configuration for web_server_proxy #2752

Dragoy opened this issue Jan 12, 2025 · 0 comments

Comments

@Dragoy
Copy link

Dragoy commented Jan 12, 2025

The web_server_proxy function in Modal, designed to proxy requests to a local web server, currently uses a hardcoded timeout of 3600 seconds (1 hour) within its internal aiohttp.ClientSession. This fixed timeout presents challenges when proxying requests to services that might require longer processing times, such as those involving machine learning model training or extensive data operations.

This lack of configurability can lead to premature termination of requests that exceed the one-hour limit, disrupting long-running tasks and negatively impacting user experience.

Proposed Solution:

Introduce a mechanism to allow customization of the aiohttp.ClientTimeout used within web_server_proxy.
Introduce a global or app-level configuration option: This would allow setting a default timeout for all web_server_proxy instances within an application.

timeout=aiohttp.ClientTimeout(total=3600),

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant