WIP: add mochi-plumber support for automatic network card selection #298
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #298 +/- ##
==========================================
- Coverage 57.89% 57.88% -0.01%
==========================================
Files 70 70
Lines 10198 10216 +18
Branches 1341 1347 +6
==========================================
+ Hits 5904 5914 +10
- Misses 3458 3465 +7
- Partials 836 837 +1 ☔ View full report in Codecov by Sentry. |
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| @@ -22,7 +22,9 @@ | |||
| if (options & MARGO_CONFIG_PRETTY_JSON) { | |||
| json_to_string_flags |= JSON_C_TO_STRING_PRETTY; | |||
| } | |||
| struct json_object* root = json_object_new_object(); | |||
| struct json_object* root = json_object_new_object(); | |||
| struct json_object* _plumber = NULL; | |||
Check notice
Code scanning / CodeQL
Unused local variable Note
| @@ -180,6 +180,9 @@ | |||
| mid->monitor->finalize(mid->monitor->uargs); | |||
| free(mid->monitor); | |||
|
|
|||
| if (mid->plumber_bucket_policy) free(mid->plumber_bucket_policy); | |||
Check notice
Code scanning / CodeQL
Guarded Free Note
| @@ -180,6 +180,9 @@ | |||
| mid->monitor->finalize(mid->monitor->uargs); | |||
| free(mid->monitor); | |||
|
|
|||
| if (mid->plumber_bucket_policy) free(mid->plumber_bucket_policy); | |||
| if (mid->plumber_nic_policy) free(mid->plumber_nic_policy); | |||
Check notice
Code scanning / CodeQL
Guarded Free Note
| @@ -387,6 +410,8 @@ | |||
| ABT_cond_free(&mid->finalize_cond); | |||
| ABT_mutex_free(&mid->pending_operations_mtx); | |||
| if (mid->current_rpc_id_key) ABT_key_free(&(mid->current_rpc_id_key)); | |||
| if (mid->plumber_bucket_policy) free(mid->plumber_bucket_policy); | |||
Check notice
Code scanning / CodeQL
Guarded Free Note
| @@ -387,6 +410,8 @@ | |||
| ABT_cond_free(&mid->finalize_cond); | |||
| ABT_mutex_free(&mid->pending_operations_mtx); | |||
| if (mid->current_rpc_id_key) ABT_key_free(&(mid->current_rpc_id_key)); | |||
| if (mid->plumber_bucket_policy) free(mid->plumber_bucket_policy); | |||
| if (mid->plumber_nic_policy) free(mid->plumber_nic_policy); | |||
Check notice
Code scanning / CodeQL
Guarded Free Note
Adds optional support for the mochi-plumber library and json parameters to configure it.