Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Memory leak with observer #16

Open
jsaunderson opened this issue Nov 21, 2018 · 1 comment
Open

Memory leak with observer #16

jsaunderson opened this issue Nov 21, 2018 · 1 comment

Comments

@jsaunderson
Copy link

jsaunderson commented Nov 21, 2018 •
edited
Loading

There is a memory leak when using an observer, this appears to be caused by mixinLifecycleEvents not patching componentWillUnmount resulting in the reaction never being disposed.

After adding patch(target, 'componentWillUnmount'); the memory leak went away.

Is there any reason it was omitted, or can it be added in?
@mweststrate
Copy link
Member

@jsaunderson Looks like that is missing indeed! Feel free to open PR

@adamansky adamansky mentioned this issue Jul 26, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Preact mobx upgrade
2 participants
@mweststrate @jsaunderson