Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Twitter Logo to New "X" Branding #187

Open
Piyush-Goenka opened this issue Sep 27, 2024 · 11 comments
Open

Update Twitter Logo to New "X" Branding #187

Piyush-Goenka opened this issue Sep 27, 2024 · 11 comments
Assignees

Comments

@Piyush-Goenka
Copy link

Piyush-Goenka commented Sep 27, 2024

Issue: Update Twitter Logo to New "X" Logo

Description

While scrolling down the page, the Twitter logo displayed is still the older version. We need to update it to the new logo, which is now referred to as "X".

Steps to Reproduce

  1. Navigate to the https://manifest.build
  2. Scroll down the page.
  3. Observe the Twitter logo.

Expected Behavior

The page should display the new "X" logo instead of the older Twitter logo.

Current Behavior

The old Twitter logo is still visible when scrolling down.

Screenshot

Screenshot 2024-09-28 at 12 56 52 AM

Suggested Solution

Replace the existing Twitter logo with the new "X" logo in the relevant files.

Thank you!

Copy link

Welcome to Manifest, thank you for adding your first issue !

@Piyush-Goenka
Copy link
Author

@SebConejo I would like to work on this issue.

@brunobuddy
Copy link
Contributor

@Piyush-Goenka go ahead, the concerned repo is https://github.com/mnfst/website

You can follow the same contributing rules as in this repo !

@nitesh2920
Copy link

nitesh2920 commented Oct 5, 2024

If this issue is still open, can I work on it? @brunobuddy @SebConejo

@Piyush-Goenka
Copy link
Author

@brunobuddy
I am unable to solve this issue please assign this issue to someone else .

@SebConejo SebConejo assigned nitesh2920 and unassigned Piyush-Goenka Oct 8, 2024
@SebConejo
Copy link
Contributor

@nitesh2920 we use lineicon. This font doesn't contain the x icon for now. Maybe we could just use an svg icon to display this one instead of calling another whole font-icon.

@nitesh2920
Copy link

@SebConejo yeah I just wanted to ask that question.

@nitesh2920
Copy link

@SebConejo I have one question I have to raise a PR in https://github.com/mnfst/website this repo instead of this as it is for backend only.

@brunobuddy
Copy link
Contributor

@nitesh2920 yes the repo is https://github.com/mnfst/website

@nitesh2920
Copy link

nitesh2920 commented Oct 8, 2024

@brunobuddy so I have to first create a issue there then raise a PR for that issue.

@nitesh2920
Copy link

@brunobuddy @SebConejo raised the PR please check mnfst/website#29 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants