Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge pull request #1 from mnfst/master #195

Closed
wants to merge 1 commit into from

Conversation

adititripathi
Copy link

@adititripathi adititripathi commented Oct 2, 2024

Duplicate code removal
Fix #171

Description

Fix 'Duplicate Code' issue in packages\core\admin\src\app\modules\shared\inputs\location-input\location-input.component.ts

Related Issues

None

How can it be tested?

Impacted packages

Check the NPM packages that require a new publication or release:

Check list before submitting

  • I have performed a self-review of my code (no debugs, no commented code, good naming, etc.)
  • I wrote the relative tests
  • I created a PR for the documentation if necessary and attached the link to this PR
  • This PR is wrote in a clear language and correctly labeled

feat(readme): update roadmap goals
Copy link

vercel bot commented Oct 2, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
manifest-schema ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 2, 2024 0:14am

@SebConejo
Copy link
Contributor

@adititripathi you didn't change any file

@SebConejo SebConejo closed this Oct 16, 2024
@SebConejo
Copy link
Contributor

@adititripathi you didn't answer since my last comment. You didn't change any file. So i close this pr. Feel free to do another one if you want to contribute.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants