Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Write test code to make sure nothing goes terribly wrong with encryption/decryption/authentication. #18

Open
koolfy opened this issue Apr 17, 2013 · 2 comments
Assignees
Milestone

Comments

@koolfy
Copy link
Collaborator

koolfy commented Apr 17, 2013

We should make a list of every known "fuckup vector" of anything security-critical we do (or use from an external library).

Then, write code to test it the best way we can.

And run this test code as often as possible when making changes to the codebase (arguably before any commit).

This will require some careful thoughts and as much external review/feedbacks as possible, but should nonetheless be considered a priority.

Marking it as part of the 1.2.0 milestone to make sure we don't forget it before the next release.

@ghost ghost assigned koolfy Apr 17, 2013
@koolfy
Copy link
Collaborator Author

koolfy commented Apr 17, 2013

I suggest performing any security operation in a completely separated C code using its own crypto primitives, and checking against these results.

That way we completely eliminate the possibility of python/potr/athything messing with the checks themselves without being detected.

@mmb
Copy link
Owner

mmb commented Nov 20, 2013

I started a test suite using unittest.

It needs a lot more tests and the weechat mock will need to have more added to it as we test more things.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants