Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SpaceTimeVariogram bit messed up #93

Open
mmaelicke opened this issue Apr 21, 2021 · 4 comments
Open

SpaceTimeVariogram bit messed up #93

mmaelicke opened this issue Apr 21, 2021 · 4 comments
Assignees
Milestone

Comments

@mmaelicke
Copy link
Owner

During the last two minor versions, we messed the SpaceTimeVariogram up. Dynamically updating parameters is not working properly anymore, the docs are way outdated and the differentiation which parameters are stored in the SpaceTimeVariogram and which are stored in the Marginals is weird and incosistend.

This is the main reminder for me to refactor the SpaceTimeVariogram until 0.6.0 is released.

@mmaelicke mmaelicke added this to the Version 0.6 milestone Apr 21, 2021
@mmaelicke mmaelicke self-assigned this Apr 21, 2021
@redhog
Copy link
Collaborator

redhog commented Apr 23, 2021

The SpaceTime Variogram also does NOT take advantage of sparse matrices :( I couldn't get it to work quickly, so just hard-coded it to not use the max_dist flag to the MetricSpace...

@danchurch
Copy link

danchurch commented Jan 6, 2023

Hi there, thanks for your very useful package. Concerning this issue, has the documentation for the spacetimevariogram class been updated? I can't find a good example for constructing a spacetimevariogram object, especially concerning how to format the time data.

@mmaelicke
Copy link
Owner Author

Hi, no unfortunately, it was not yet updated. I'll take this as another comment and reminder to do this somewhere near in the future.
Concerning the data: The coordinates are passed just like for the other variogram classes. Unlike array, In SciKit-GStat, the time axis is not considered a coordinate axis, so only the spatial coordinates are considered here. The values are then a 2D matrix instead of a 1D array. The shape is (sample_size, n_timesteps). Thus, the rows of coordinates and values need to match.
In case you are coming from pandas/polars etc. and you are using a DatetimeIndex, you need to transpose the data, before you pass it to the SpaceTimeVariogram.

Sorry, it's still not updated. I hope to find some time soon.

@danchurch
Copy link

No need for apologies. I am trying to use features you haven't fully developed yet. I'm grateful you have put this package out there and are maintaining it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants