Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

computation time of DirectionalVariogram #187

Open
mserouar opened this issue Jul 10, 2024 · 3 comments
Open

computation time of DirectionalVariogram #187

mserouar opened this issue Jul 10, 2024 · 3 comments

Comments

@mserouar
Copy link

mserouar commented Jul 10, 2024

Hello there !

I was wondering if it was possible to make this function faster : skg.DirectionalVariogram(list(zip(data.x, data.y)), data.m, azimuth=90, maxlag=100, n_lags=5).
Knowing that length of list(zip(data.x, data.y)) is only of 1500 and takes ~4-5s.

Thanks !

@mmaelicke
Copy link
Owner

Hi there,

I can confirm that the directional variogram is really slow. It used to be faster. I am not sure when the performance started dropping; I will have to investigate some test-logos and check when the last changes have been made to that class.
Do you just wish to have it faster, or do you also have an idea, how that could be achieved?

I have to admit, that I don't have much time right now to make substantial progress in this package.

@mserouar
Copy link
Author

I just wanted to know if it was a known issue, first of all, if there was a reason for that computational delay faced to the 'simple' Variogram class.
I didn't expect any action from you, simply curious. But if I also have some time, I may have a look.
Thanks a lot !

@mmaelicke
Copy link
Owner

This is a new issue for me, and I feel like this should be faster, so I think I might consider this a bug.

Currently, I just have no idea if that is actually the case and if so, how to solve that. So, I will eventually look into it and until then, any hint is appreciated ^^

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants