Bug in MetricSpace

[mmaelicke]

Hey @redhog

I think there is still a bug in MetricSpace related to the setting of maxlag. You can reproduce the example below with the newly introduced data module of scikit-gstat:

import skgstat as skg
c, v = skg.data.pancake().get('sample')

V = skg.Variogram(c, v, n_lags=20)
V.plot()

gives:

If you build the variogram like:

V = skg.Variogram(c, v, n_lags=20, maxlag=500)

we get:

I guess the problem is the MetricSpace as it gets instantiated differently when maxlag is not an integer > 1. If I pass a float < 1 things seem to work properly:

Something that could be related:
I fixed an issue here:

scikit-gstat/skgstat/Variogram.py

Line 254 in 259c10f

if samples is None:

Formerly, this line looked like:

if maxlag == None:

For which pylint was always complaining cause it's bad practice.

I can somehow remember that you fixed a similar issue already, so maybe you know what is going wrong here.