diff --git a/R/PipeOpFDAExtract.R b/R/PipeOpFDAExtract.R index fc25cef..ff64a9f 100644 --- a/R/PipeOpFDAExtract.R +++ b/R/PipeOpFDAExtract.R @@ -111,7 +111,7 @@ PipeOpFDAExtract = R6Class("PipeOpFDAExtract", param_set = param_set, param_vals = param_vals, packages = c("mlr3fda", "mlr3pipelines", "tf"), - feature_types = c("tfd_irreg", "tfd_reg"), + feature_types = c("tfd_reg", "tfd_irreg"), tags = "fda" ) } diff --git a/R/PipeOpFDATSFeatures.R b/R/PipeOpFDATSFeatures.R index 2c3fca6..6105591 100644 --- a/R/PipeOpFDATSFeatures.R +++ b/R/PipeOpFDATSFeatures.R @@ -78,7 +78,7 @@ PipeOpTSFeatures = R6Class("PipeOpTSFeatures", param_set = param_set, param_vals = param_vals, packages = c("mlr3fda", "mlr3pipelines", "tf", "tsfeatures"), - feature_types = "tfd_reg", + feature_types = c("tfd_reg", "tfd_irreg"), tags = "fda" ) } diff --git a/tests/testthat/test_PipeOpFDATSFeatures.R b/tests/testthat/test_PipeOpFDATSFeatures.R index 4a7e6cb..fbc7113 100644 --- a/tests/testthat/test_PipeOpFDATSFeatures.R +++ b/tests/testthat/test_PipeOpFDATSFeatures.R @@ -12,4 +12,11 @@ test_that("PipeOpFDATSFeatures works", { expect_task(task_tsfeats) expect_identical(dim(new_data), c(129L, 34L)) expect_named(new_data, names(new_data)) + + # irregular data works + task = tsk("dti") + pop = po("fda.tsfeats") + task_tsfeats = train_pipeop(pop, list(task))[[1L]] + new_data = task_tsfeats$data() + expect_task(task_tsfeats) })