Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feedback to MLIR #58

Open
raviqqe opened this issue Sep 19, 2022 · 4 comments
Open

Feedback to MLIR #58

raviqqe opened this issue Sep 19, 2022 · 4 comments
Labels
help wanted Extra attention is needed

Comments

@raviqqe
Copy link
Member

raviqqe commented Sep 19, 2022

  • Lack of API to check if dialects are loaded in contexts.
    • But this is possible operation-wise via mlirContextIsRegisteredOperation().
  • String refs as inputs need to be null-terminated (C-style) strings.
    • The documentation says both are fine...
  • Use after move of operations, regions, and blocks
  • LLVM bitcode emission
    • This is possible only with a mlir-translate command right now.
  • mlirMemRefTypeGetElementType()
    • Use the ShapedType API.

References

@raviqqe raviqqe added the help wanted Extra attention is needed label Sep 23, 2022
@edg-l
Copy link
Member

edg-l commented May 18, 2023

Access to the datalayout api https://mlir.llvm.org/docs/DataLayout/

@Danacus
Copy link
Contributor

Danacus commented Jul 15, 2023

Access to rewrite patterns (https://mlir.llvm.org/docs/PatternRewriter/), but mainly to use PDL modules (https://mlir.llvm.org/doxygen/classmlir_1_1PDLPatternModule.html) as they can be represented as MLIR using the PDL dialect.

See also: https://github.com/beaver-lodge/beaver/blob/main/native/mlir-c/lib/CAPI/Elixir.cpp#L17

@edg-l
Copy link
Member

edg-l commented Mar 5, 2024

I'm implementing the llvm debug info attributes in the C api: llvm/llvm-project#83992 to achieve nice debug info for mlir programs

@edg-l
Copy link
Member

edg-l commented Mar 8, 2024

I'm implementing the llvm debug info attributes in the C api: llvm/llvm-project#83992 to achieve nice debug info for mlir programs

Got this merged!

Im doing another one llvm/llvm-project#84453

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

3 participants