Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scoring updates #618

Merged
merged 54 commits into from
Feb 1, 2024
Merged

Scoring updates #618

merged 54 commits into from
Feb 1, 2024

Conversation

priyakasimbeg
Copy link
Contributor

@priyakasimbeg priyakasimbeg commented Jan 19, 2024

Addresses:

Changes to pay attention to during review:

  • PRNG Key splitting in run_workloads.py, from submission group to studies to workload trials.
  • behavior of strict flag in scoring which will put strict requirements regarding number of trials and studies on a submission.

Todo:

  • Add script to generate held-out workloads
  • Add held-out workload sampling in script that runs workloads for submission
  • Add sampling for studies and trials for in script that runs workloads for submission
  • Add instructions for running workloads and scoring submissions

Copy link

github-actions bot commented Jan 19, 2024

MLCommons CLA bot All contributors have signed the MLCommons CLA ✍️ ✅

@priyakasimbeg priyakasimbeg changed the title Scoring fixes Scoring updates Jan 19, 2024
@priyakasimbeg priyakasimbeg changed the title Scoring updates [WIP] Scoring updates Jan 19, 2024
@priyakasimbeg priyakasimbeg changed the title [WIP] Scoring updates Scoring updates Jan 29, 2024
@priyakasimbeg priyakasimbeg marked this pull request as ready for review January 29, 2024 17:58
@priyakasimbeg priyakasimbeg requested a review from a team as a code owner January 29, 2024 17:58
Copy link
Contributor

@georgedahl georgedahl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wrote some of these comments before we met yesterday, so if they contradict that discussion consider them obsolete. Posting them for completeness. Someone else should review the performance profile changes carefully in addition to another full review once you've updated this.

GETTING_STARTED.md Outdated Show resolved Hide resolved
GETTING_STARTED.md Outdated Show resolved Hide resolved
scoring/held_out_workloads_example.json Outdated Show resolved Hide resolved
scoring/performance_profile.py Outdated Show resolved Hide resolved
scoring/score_submissions.py Outdated Show resolved Hide resolved
@priyakasimbeg
Copy link
Contributor Author

I'm going to merge this into Dev.
Will add tests for code in performance_profile.py in a separate PR in which we can double check the correctness of the scoring calculations.

@priyakasimbeg priyakasimbeg merged commit ff3c9b0 into dev Feb 1, 2024
31 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Feb 1, 2024
@priyakasimbeg priyakasimbeg deleted the scoring_fixes branch March 29, 2024 00:43
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants