Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add workload variants for ImageNet ViT #599

Merged
merged 8 commits into from
Jan 4, 2024
Merged

Conversation

pomonam
Copy link
Contributor

@pomonam pomonam commented Dec 9, 2023

This PR adds 3 variants for ImageNet ViT workloads:

  1. Post-LN: Layer normalization applied after the residual branch.
  2. MAP: Applied multihead attention pooling.
  3. GLU: Included gated linear units in the MLPBlock.

In addition, I added modeldiff tests for the first two variants, and they passed (there was a bug in the test, and this was also fixed).

@pomonam pomonam requested a review from a team as a code owner December 9, 2023 04:32
Copy link

github-actions bot commented Dec 9, 2023

MLCommons CLA bot All contributors have signed the MLCommons CLA ✍️ ✅

@priyakasimbeg
Copy link
Contributor

Hi Juhan, this looks great thank you! Were you planning on adding the modeldiff / fprop test for the MAP variant as well?

@pomonam
Copy link
Contributor Author

pomonam commented Dec 14, 2023

Thank you! Not yet - if you want to add the variants in the repo immediately, we can push this, and I will make a separate PR. But if it is not something urgent, I should be able to add modeldiff test next week.

@priyakasimbeg priyakasimbeg merged commit e20d41f into dev Jan 4, 2024
31 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Jan 4, 2024
@priyakasimbeg priyakasimbeg deleted the juhan/vit_variant2 branch February 10, 2024 01:58
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants