punycode module is deprecated in MJML 4.15.3 on Node.js 22.12.0 LTS

[mudge]

Describe the bug
Using MJML on the current LTS version of Node.js (22.12.0) will emit the following deprecation warning:

W, [2025-01-08T13:35:55.110352 #46507]  WARN -- Mjml: (node:46643) [DEP0040] DeprecationWarning: The `punycode` module is deprecated. Please use a userland alternative instead.

To Reproduce
Steps to reproduce the behavior:

1. Create a file called test.mjml with this MJML code: <mjml><mj-body><mj-section><mj-column><mj-text>Hello World</mj-text></mj-column></mj-section></mj-body></mjml>
2. Render it to HTML by doing 'mjml test.mjml' on Node.js 22.12.0
3. See deprecation warning

Expected behavior
No deprecation warning should be emitted.

MJML environment (please complete the following information):

• OS: macOS 15.2
• MJML Version: 4.15.3
• MJML tool used: mjml JavaScript package

Additional context
This was previously discussed in #2843 and is seemingly fixed in the alpha versions of MJML 5: would it be possible to backport the fix to MJML 4?

[iRyusa]

Not on top of my priority for now, you should use the 5.x branch instead

[mudge]

We're using MJML with MJML-Rails which explicitly checks for version 4 and raises an error if mjml --version doesn't match. We could override that or is it worth raising an issue with that project for version 5 support if that is what is now recommended (despite still being in alpha)?

[iRyusa]

I’m doing my best with the free time I have. Mjml 4 has a running CVE which could affect you too. And I know it sucks to rely on alpha, which in fact runs perfectly fine in production on multiple project I have.On 8 Jan 2025, at 17:13, Paul Mucur ***@***.***> wrote: We're using MJML with MJML-Rails which explicitly checks for version 4 and raises an error if mjml --version doesn't match. We could override that or is it worth raising an issue with that project for version 5 support if that is what is now recommended (despite still being in alpha)? —Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you commented.Message ID: ***@***.***>

[mudge]

Thanks for taking the time to look at this.

The diff between 4.15.3 and 5.0.0-alpha.6 seems reasonable and MJML-Rails' mjml_binary_version_supported is designed to be configurable so I'm happy to customise this in our own applications to switch to MJML 5.

Would it be worth making a GitHub release for https://github.com/mjmlio/mjml/releases/tag/v5.0.0-alpha.6 (still marking it as a prerelease) and summarising the changes from 4 in order to indicate its readiness for use?

[iRyusa]

It's a "breaking" version because we change the lib we relied on for formating & minifying HTML. So it's not a big change for the end-user yeah

…

On Wed, Jan 8, 2025 at 6:42 PM Paul Mucur ***@***.***> wrote: The diff between 4.15.3 and 5.0.0-alpha.6 <v4.15.3...v5.0.0-alpha.6> seems reasonable and MJML-Rails' mjml_binary_version_supported is designed to be configurable <v4.15.3...v5.0.0-alpha.6> so I'm happy to customise this in our own applications to switch to MJML 5. Would it be worth making a GitHub release for https://github.com/mjmlio/mjml/releases/tag/v5.0.0-alpha.6 (still marking it as a prerelease) and summarising the changes from 4? — Reply to this email directly, view it on GitHub <#2930 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAELHTNCNZ4QN4M3VKRMF4L2JVPRRAVCNFSM6AAAAABUZ7BPD6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDKNZYGI2TMNBWHE> . You are receiving this because you commented.Message ID: ***@***.***>