Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error with Stems in directories with special symbols (Addendum to #13550) #13783

Open
Eve00000 opened this issue Oct 19, 2024 · 1 comment
Open
Labels

Comments

@Eve00000
Copy link
Contributor

Bug Description

I wanted to reorganize my library, put stems at the same place of the original.
Importing the stem is no problem, opening (analyzing or player) makes Mixxx crash.

Deduction of the problem learns:
F:\Music#0500 - Artists\Anne Clark\Anne Clark - Best Of Anne Clark (1992)\19 Anne Clark - Our Darkness (12_).stem.m4a
plays perfect, analazer, deck, sampler ...
F:\Music#0500 - Artists\Anne Clark •\Anne Clark - Best Of Anne Clark (1992)\19 Anne Clark - Our Darkness (12_).stem.m4a
makes Mixxx crash. Normal ALAC files in this directory play fine.

The difference betweeb the 2 locations is the " •" after the name in the artist directory (to mark a directory as a Artist Container).

I compaired
src\sources\soundsourceffmpeg.cpp
src\sources\soundsourceflac.cpp
src\sources\soundsourcemp3.cpp
src\sources\soundsourcestem.cpp
src\sources\soundsourceopus.cpp
src\sources\soundsourcewv.cpp
src\sources\soundsourcem4a.cpp
they all have a different way to translate the location,
I will highlight the windows lines

M4A:
m_hFile = MP4Read(getLocalFileName().toUtf8().constData(), 0);
Opus:
QByteArray qBAFilename = getLocalFileName().toUtf8();
...
in some cases the filename is converted to utf8 and const, on otherr formats it isn't.

I played around with converting the "getLocalFileName()" without success.
I think #13550 suffers of a similar problem.
As I can remember 2.3.4 (or 5) had the same problem with " •" and other symbols for all files but the next release solved that.
I tried to find the pr / solution but couldn't find it.

Version

2.5 & 2.6

OS

Win

@Eve00000 Eve00000 added the bug label Oct 19, 2024
Eve00000 added a commit to Eve00000/mixxx that referenced this issue Oct 19, 2024
This change solves the problem when special charactersare in the name of the directories containing stems.
In my case ' •'
See issue mixxxdj#13783.
@Eve00000
Copy link
Contributor Author

Solved in PR #13784

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant