Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add bar and phrase marks to waveform #11519

Closed
JaviVilarroig opened this issue Apr 29, 2023 · 5 comments
Closed

Add bar and phrase marks to waveform #11519

JaviVilarroig opened this issue Apr 29, 2023 · 5 comments
Labels
beatgrid duplicate This issue is a duplicate of or superseded by another issue. feature

Comments

@JaviVilarroig
Copy link
Contributor

Feature Description

When I mix two tracks and to make the transition sound better, I always try to align the phrases or ate least the bars in the two tracks.

Right now I have no visual clue in Mixxx wave forms on where are phrases and bars starting. That means that I must be counting beats, bars and phrases to have that information. This is error prone and require extra concentration on my side not to get lost in counting.

I want to have that visual indications available to make my dijing more enjoyable. I will then be able to concentrate on delivering a good sounding mixes to my audience.

@ronso0
Copy link
Member

ronso0 commented Apr 29, 2023

I'd say this is a duplicate of #10164

Please reopen if you think it's worth tracking this seperately.

@ronso0 ronso0 closed this as completed Apr 29, 2023
@ronso0 ronso0 added duplicate This issue is a duplicate of or superseded by another issue. beatgrid labels Apr 29, 2023
@JaviVilarroig
Copy link
Contributor Author

I can accept that.

I was unable to fins a related ticket because I was looking for bars and phrases.

FYI. As it's me wanting this feature. I will to try again to have it done by myself. The last try, 3(?) years ago was unsuccessful. So, I will start from scratch.

@ronso0
Copy link
Member

ronso0 commented Apr 30, 2023

Note there is WIP #4489, so I suggest to not waste time on an alternative implementation but help with that instead (testing & reviewing).

@JaviVilarroig
Copy link
Contributor Author

Hi.

I have taken a look. And this PR states that it's a proof of concept. It's not really aiming at a something that can be achieved in a simpler way, at least for the mos basic use cases. And it's more or less dormant.

Anyway, I will try to see if it can be revived. But I can't promise anything. :)

@JoergAtGithub
Copy link
Member

FYI. As it's me wanting this feature. I will to try again to have it done by myself. The last try, 3(?) years ago was unsuccessful. So, I will start from scratch.

You will not start from scratch, since your last try, @hacksdump and @Holzhaus did a lot of work on the foundation. Have a look at all the merged PRs at: https://github.com/mixxxdj/mixxx/projects/6
Many design decisions are taken and we have a common data model for fixed and flexible beat grid now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
beatgrid duplicate This issue is a duplicate of or superseded by another issue. feature
Projects
None yet
Development

No branches or pull requests

3 participants