Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show all deck waveforms in a common time range #11247

Open
atskler opened this issue Feb 4, 2023 · 5 comments
Open

Show all deck waveforms in a common time range #11247

atskler opened this issue Feb 4, 2023 · 5 comments
Labels

Comments

@atskler
Copy link

atskler commented Feb 4, 2023

Feature Description

I think it would be a good thing to show all the deck waveforms in a common time range, so in this way the loaded tracks can be easily compared and checked to each other and regarding where one is in time. (Also additional minute markers could be implemented.)

So for example the deck time display is set to 10 min range, and the 7 min track and the 4 min track would be shown in this 10 min range.

@atskler atskler added the feature label Feb 4, 2023
@daschuer
Copy link
Member

daschuer commented Feb 4, 2023

Can you do a mockup be editing a screenshot with Gimp or any other photo editor?

@ronso0
Copy link
Member

ronso0 commented Feb 4, 2023

I understand the desire for this kind of display, though it only works for a certain range of durations, or let's say if both (all 4 tracks) have a duration of the same scale.
Otoh, if I have a regular 'radio track' with just 4-5 min in deck1 and then load a 30 min long field recording to drop some samples over track1, the short track's overview would be squeezed and most of the waveform information is lost IMO.

Would minute markers help you? #5843

@atskler
Copy link
Author

atskler commented Feb 4, 2023

A 10 min view would look something like the attached image. Minute marks are optional.
Also besides manual setting, this time range may be optionally automatically set based on the longest track.
Also the waveform should respond to tempo adjustments.

Alternatively this view range could be also based on beats not just on time.

fig

@atskler
Copy link
Author

atskler commented Feb 4, 2023

@ronso0 this should not be a must, and the new and only way but an optional helpful thing, probably accessible from the ui by some buttons.

Sure it can be superfluous or impractical for some people or use cases, just as for me the autodj feature is and all the development and debugging effort that goes into it, but for others just as that, also this could be helpful, useful. (Anyways that small view would be almost useless for 30 min - and why not say 90+ min - recording. Maybe it should be zoomable and scrollable/pageable, but that would be another feature request, and I would also support that.)

The #5843 will help me not, as it will not make the two tracks easily comparable by sight. And the stretched waveforms will still inadvertently suggest same length for a 8 min and 3 min track.

@mxmilkiib
Copy link
Contributor

When the main waveforms are displayed in parallel style, now default, and the zoom level is set to be synced between all waveforms, then they are all in a common time range, no?

The only issue, imo, is that one cannot zoom out to see the entirety of a waveform, which is #6682.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants