Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Android and iOS modules to allow compilation on mobile platforms #8

Open
gibutm opened this issue Nov 17, 2020 · 1 comment
Open

Comments

@gibutm
Copy link

gibutm commented Nov 17, 2020

Presently the plugin only supports Desktop platforms (macos, linux and windows). When compiling a project that depends on desktop_window for mobile platform (android and ios), compilation will always fail as there are no modules set up for this plugin.
I'm not sure if this plugin could have an overloaded usage for the mobile platform but a simple no-op implementation would be useful to allow consumption in projects that have a single codebase for mobile and desktop platforms.

What do you think? I am willing to raise a PR if that helps.

@Robert3141
Copy link

A solution to this is to wrap all of the references to this package in the conditon below:

import
if (kIsWeb
      ? false
      : Platform.isWindows || Platform.isLinux || Platform.isMacOS) {
}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants